Ruff rules for comprehensions and performance #168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%
ruff check --select=C4,C90,PERF --statistics
In
micropip/externals/mousebender/simple.py
, Mypy is a bit behind pyupgrade on Python 3.12.%
ruff rule C408
unnecessary-collection-call (C408)
Derived from the flake8-comprehensions linter.
Fix is always available.
What it does
Checks for unnecessary
dict()
,list()
ortuple()
calls that can berewritten as empty literals.
Why is this bad?
It's unnecessary to call, e.g.,
dict()
as opposed to using an emptyliteral (
{}
). The former is slower because the namedict
must belooked up in the global scope in case it has been rebound.
Examples
Use instead:
Fix safety
This rule's fix is marked as unsafe, as it may occasionally drop comments
when rewriting the call. In most cases, though, comments will be preserved.
Options
lint.flake8-comprehensions.allow-dict-calls-with-keyword-arguments